Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0.2xx] Use the static factory for creating a logger #45009

Draft
wants to merge 2 commits into
base: release/9.0.2xx
Choose a base branch
from
Draft

[release/9.0.2xx] Use the static factory for creating a logger #45009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e8bf0f
Use the static factory for creating a logger
MichalPavlik Nov 21, 2024
f558948
Merge branch 'release/9.0.2xx' into dev/mipavlik/fix-dotnet-run
MichalPavlik Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Cli/dotnet/commands/dotnet-run/RunCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,12 @@ public void Shutdown()
static ILogger MakeTerminalLogger(VerbosityOptions? verbosity)
{
var msbuildVerbosity = ToLoggerVerbosity(verbosity);
var thing = Assembly.Load("MSBuild").GetType("Microsoft.Build.Logging.TerminalLogger.TerminalLogger")!.GetConstructor([typeof(LoggerVerbosity)])!.Invoke([msbuildVerbosity]) as ILogger;
return thing!;
var logger = Assembly.Load("MSBuild")
.GetType("Microsoft.Build.Logging.TerminalLogger.TerminalLogger")!
.GetMethod("CreateTerminalOrConsoleLogger")!
.Invoke(null, [msbuildVerbosity]) as ILogger;

return logger!;
}

static string ComputeRunArgumentsTarget = "ComputeRunArguments";
Expand Down
Loading