Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update perf run yaml with changes for crank on helix #90368

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

caaavik-msft
Copy link
Contributor

As part of the work to get crank on helix in the performance repository, we need to install the dataclasses pip package on the agents. This PR needs to be merged in after the Crank runner for Helix change is merged

@ghost
Copy link

ghost commented Aug 11, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

As part of the work to get crank on helix in the performance repository, we need to install the dataclasses pip package on the agents. This PR needs to be merged in after the Crank runner for Helix change is merged

Author: caaavik-msft
Assignees: caaavik-msft
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caaavik-msft caaavik-msft merged commit bbe40f8 into dotnet:main Aug 11, 2023
98 checks passed
radical added a commit to radical/runtime that referenced this pull request Aug 11, 2023
…90368)"

This reverts commit bbe40f8.

This caused perf pipeline runs to break.

Issue: dotnet#90420
radical added a commit that referenced this pull request Aug 11, 2023
#90424)

This reverts commit bbe40f8.

This caused perf pipeline runs to break. But dotnet/performance#3251 from @caaavik-msft, along with this revert will fix the issue.

Issue: #90420
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants