-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Syntax of the GC Pipeline Yaml #4489
Conversation
mrsharm
commented
Sep 27, 2024
•
edited
Loading
edited
- Fixing Syntax of the GC Pipeline Yaml.
- Temporarily disable long running examples to get the pipeline running.
- Excluding running the performance pipeline in case no changes are made in the GC Infra.
@mrsharm it would probably be worth adding the gc-azure-pipelines.yml file to the normal azure-pipelines.yml exclude list, and maybe adding it to the include list of the gc-azure-pipelines.yml file (I am not sure if a yml considers itself as always in the include list or not 🤷♂️). This would minimize the noise from the performance scenario runs unrelated to GC in the GC commits. |
/azp run performance-gc-ci |
No pipelines are associated with this pull request. |
/azp run performance-gc-ci |
No pipelines are associated with this pull request. |
/azp run performance-gc-ci |
No pipelines are associated with this pull request. |
/azp run performance-gc-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment. Looks good overall as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍.
Thanks for all the help, @LoopedBard3 and @DrewScoggins! This PR has got us to test a large part of the notebook functionality and I observe that the tests are all green from the pipeline: And successfully running the tests: https://dev.azure.com/dnceng-public/public/_build/results?buildId=822709&view=logs&j=6f2f97bc-132f-5f9d-ae17-411e38c19357 Will follow up with re-enabling the example notebook tests as these are timing out on the lab machines even though successfully running locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM