Check for Empty ASP.NET Benchmark Filters + Documentation #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maoni0
previously approved these changes
Feb 1, 2024
|
@cincuranet, could we please merge this? It's ready as the MD linting is fixed. Thanks in advance! |
markples
reviewed
Feb 1, 2024
| @@ -217,6 +217,19 @@ It's worth noting that if you have specified Linux based binaries in the corerun | |||
| 1. Remove the ``crank`` prefix from the command line. | |||
| 2. Remove the ``--application.aspNetCoreVersion``, ``--application.runtimeVersion`` and ``--application.sdkVersion`` command args from the command line that you paste in the CSV as the versions are set by the infrastructure itself. | |||
|
|
|||
| ###### How To Filter Benchmarks | |||
|
|
|||
| You can filter benchmarks of interest from the entire set of benchmarks specified by the referenced `benchmarks_file` using a list of regex patterns such as the following in the `benchmark_settings` section: | |||
There was a problem hiding this comment.
wording nit - The use of * is a wildcard pattern rather than a regex. I assume that Foo* is such a common pattern that you don't want to only support regexes (Foo.*), but it makes explanation difficult. (see also the exception message and that the implementation doesn't handle something like Foo*Bar* as might be expected or ? - I assume that you don't want to dive into more implementation on this, so maybe something like "regex or pattern with trailing * wildcard" is good enough?)
There was a problem hiding this comment.
I agree - will update this in the next round of doc changes. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.