Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MDs #3358

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix MDs #3358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26dfcfe
Fix images in perfreport-walkthrough
cincuranet Sep 20, 2023
f8e31ce
Fix trailing space in perfreport-walkthrough
cincuranet Sep 20, 2023
f6dece5
Fix title anchor link
cincuranet Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/benchmarking-workflow-dotnet-runtime.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Benchmarking workflow for [dotnet/runtime](https://github.com/dotnet/runtime) repository
# Benchmarking workflow for [dotnet/runtime](https://github.com/dotnet/runtime) repository {#top}

## Table of Contents

- [Benchmarking workflow for dotnet/runtime repository](#benchmarking-workflow-for-dotnetruntime-repository)
- [Benchmarking workflow for dotnet/runtime repository](#top)
- [Table of Contents](#table-of-contents)
- [Introduction](#introduction)
- [Code Organization](#code-organization)
Expand Down
18 changes: 9 additions & 9 deletions docs/perfreport-walkthrough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,32 @@ Link to a [Test Report](https://pvscmdupload.blob.core.windows.net/autofilerepor

When looking at a report start by clicking on the small chart on the left side of the row.

<img width="1871" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/0428d1db-15fc-4440-b587-9e37ec25baa9">
![image](https://github.com/dotnet/runtime/assets/9439069/0428d1db-15fc-4440-b587-9e37ec25baa9)

This will bring up a larger version of the graph. You can zoom, pan, and select an area for zoom using the controls on the graph overlay.

<img width="1874" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/7a36cfe6-b8e5-417f-a725-e45def66f223">
![image](https://github.com/dotnet/runtime/assets/9439069/7a36cfe6-b8e5-417f-a725-e45def66f223)

Use the selection tool to focus in on the part of the graph that shows the regression.

<img width="753" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/13dcea0f-5055-4d26-8bff-15d3154e4ef7">
![image](https://github.com/dotnet/runtime/assets/9439069/13dcea0f-5055-4d26-8bff-15d3154e4ef7)

After that it will be easy to click the point right before when the regression occurred. When you click that point you will get a fly-out that has several options. `Set Baseline` `Set Compare` and `Clear Comparison`. It works best to click your baseline point first and then click `Set Baseline`.

<img width="992" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/bfbf35c2-2639-488f-a753-367ff0169c08">
![image](https://github.com/dotnet/runtime/assets/9439069/bfbf35c2-2639-488f-a753-367ff0169c08)

Once you have the baseline set you can close the fly-out by clicking on the red X.

<img width="763" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/be7b5d01-a1ac-4caf-94e3-ad0542e4f74f">
![image](https://github.com/dotnet/runtime/assets/9439069/be7b5d01-a1ac-4caf-94e3-ad0542e4f74f)

Now, click the compare point, in this case you want to click the point that is closest to the baseline point that shows the regression.
Now, click the compare point, in this case you want to click the point that is closest to the baseline point that shows the regression.

<img width="830" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/dd86cd1a-6079-4022-af04-1f46df3c595f">
![image](https://github.com/dotnet/runtime/assets/9439069/dd86cd1a-6079-4022-af04-1f46df3c595f)

After that click the `Set Compare` button.

<img width="947" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/a7b10a83-ad99-4672-aecb-e5312556b045">
![image](https://github.com/dotnet/runtime/assets/9439069/a7b10a83-ad99-4672-aecb-e5312556b045)

This will bring up a link to the runtime repo that will do a comparison between the git commit hashes of the two points that were set as the baseline and compare.

<img width="896" alt="image" src="https://github.com/dotnet/runtime/assets/9439069/25e48d06-6faf-4153-801d-fe40b28d3354">
![image](https://github.com/dotnet/runtime/assets/9439069/25e48d06-6faf-4153-801d-fe40b28d3354)
4 changes: 2 additions & 2 deletions docs/profiling-workflow-dotnet-runtime.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Profiling workflow for [dotnet/runtime](https://github.com/dotnet/runtime) repository
# Profiling workflow for [dotnet/runtime](https://github.com/dotnet/runtime) repository {#top}

## Table of Contents

- [Profiling workflow for dotnet/runtime repository](#profiling-workflow-for-dotnetruntime-repository)
- [Profiling workflow for dotnet/runtime repository](#top)
- [Table of Contents](#table-of-contents)
- [Introduction](#introduction)
- [Prerequisites](#prerequisites)
Expand Down