Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixed HeaderFooterGrid to pass on CV1 and CV2 #26022

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devanathan-vaithiyanathan
Copy link
Contributor

@devanathan-vaithiyanathan devanathan-vaithiyanathan commented Nov 21, 2024

Issue details

The size of the CollectionView, including the header and footer, is not rendered correctly on the UI in CV1 but displays correctly in CV2.

Root cause

The GetSize() method calculated the size of the CollectionView based only on its content, ignoring the header and footer sizes. This caused incorrect height or width rendering when a header or footer was used.

Description of Change

The fix calculates the sizes of the header and footer using helper methods, This ensures the total size includes all elements, and the result is adjusted to fit within the CollectionView bounds.

Issues Fixed

Fixes #25773

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output Screenshot

Before After

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 21, 2024
Copy link
Contributor

Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added platform/iOS 🍎 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Fix HeaderFooterGrid to pass on CV1 and CV2
3 participants