Fixed Extra Padding on iOS buttons required when image on top or bottom #26018
+116
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 21, 2024
| titleInsets.Left -= imageWidth / 2; | ||
| titleInsets.Right += imageWidth / 2; | ||
| // Which makes the later math easier to follow | ||
| if (layout.Position == ButtonContentLayout.ImagePosition.Left || layout.Position == ButtonContentLayout.ImagePosition.Right) |
There was a problem hiding this comment.
This change will impact to several tests:
There was a problem hiding this comment.
Changes in the screenshot tests should be expected if this is working correctly so that is not necessarily a bad thing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
When the image is positioned at the top or bottom with the title, extra padding is added to the left and right sides of the button.
Root Cause
When the button content layout is set to 'Top' or 'Bottom,' the button content width is recalculated based on both the title width and the image width.
Description of Change
Validated the behaviour in the following platforms
Issues Fixed
Fixes #25489
Output