-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SyntaxContext #2245
Draft
curin
wants to merge
11
commits into
dotnet:develop/3.0
Choose a base branch
from
curin:develop/3/Syntax-Context
base: develop/3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Adding SyntaxContext #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit
Unified TypeContextContainer code Added Parameter tracking for methods
-added some BaseType tracking -added member tracking in Enums for easier combining -added support for generic types
curin
force-pushed
the
develop/3/Syntax-Context
branch
from
July 12, 2024 20:30
4f79555
to
1e2df16
Compare
-finished Enum rewrite -working on other types rewrite (class, struct, record, etc.) -added new CSharpSyntaxRewriter to hold extra metadata
curin
force-pushed
the
develop/3/Syntax-Context
branch
from
July 15, 2024 12:37
215b049
to
86470b8
Compare
-Added Query functions -Finished Type Rewrites -Stubbed in both Namespace and CompilationUnit Rewrites -Moved IBaseTypeContext out to its own file
-also fixed some bugs
Also added some missing code for rewrite
curin
force-pushed
the
develop/3/Syntax-Context
branch
from
July 17, 2024 19:36
1cb2b82
to
a3436e7
Compare
-Adding support for Delegates, Indexers, and Events -Delegates is incomplete
-added some type cleanup as well
Also added to the interfaces and fixed some potential issues related to editing a list within a foreach loop
Is this dead now we're delegating to Roslyn? |
I meant to ask a question not answer it lmao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds the SyntaxContext object to better interact with the whole syntax tree. Reworks the mods system to use this instead of the GeneratedSyntax object, which is instead used as part of the SyntaxContext construction.