Unit tests for peripheral #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelByszewski
force-pushed
the
feature/unit_tests
branch
from
7ea2b71
to
20c8126
Compare
mikolak
reviewed
Mar 5, 2020
mikolak
reviewed
Mar 6, 2020
| Descriptor.fromJson(Map<String, dynamic> jsonObject, | ||
| Characteristic characteristic, ManagerForDescriptor manager, | ||
| {TransactionIdGenerator transactionIdGenerator = | ||
| TransactionIdGenerator.INSTANCE}) |
There was a problem hiding this comment.
Suggested change
| TransactionIdGenerator.INSTANCE}) | |
| TransactionIdGenerator.INSTANCE,}) |
and run formatter
| Peripheral.fromJson(Map<String, dynamic> json, ManagerForPeripheral manager) | ||
| Peripheral.fromJson(Map<String, dynamic> json, ManagerForPeripheral manager, | ||
| {TransactionIdGenerator transactionIdGenerator = | ||
| TransactionIdGenerator.INSTANCE}) |
There was a problem hiding this comment.
Suggested change
| TransactionIdGenerator.INSTANCE}) | |
| TransactionIdGenerator.INSTANCE,}) |
and run formatter
| Service.fromJson(Map<String, dynamic> jsonObject, Peripheral peripheral, | ||
| ManagerForService managerForService, | ||
| {TransactionIdGenerator transactionIdGenerator = | ||
| TransactionIdGenerator.INSTANCE}) |
There was a problem hiding this comment.
Suggested change
| TransactionIdGenerator.INSTANCE}) | |
| TransactionIdGenerator.INSTANCE,}) |
and run formatter
|
|
||
| InternalBleManager() { | ||
| InternalBleManager({TransactionIdGenerator transactionIdGenerator = TransactionIdGenerator.INSTANCE}) { |
There was a problem hiding this comment.
Suggested change
| InternalBleManager({TransactionIdGenerator transactionIdGenerator = TransactionIdGenerator.INSTANCE}) { | |
| InternalBleManager({TransactionIdGenerator transactionIdGenerator = TransactionIdGenerator.INSTANCE,}) { |
and run formatter
| static int _id = 0; | ||
| static const TransactionIdGenerator INSTANCE = const TransactionIdGenerator._internal(); |
| TransactionIdGenerator transactionIdGenerator; | ||
|
|
||
| setUp((){ | ||
| transactionIdGenerator = TransactionIdGenerator.INSTANCE; |
There was a problem hiding this comment.
This will be the same instance in both tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.