Update workflows and refactor code format. (#9)

* code format * only arduino vendor. * version. * year
dojyorin · Aug 17, 2024 · ccfebd2 · ccfebd2
1 parent 658f777
commit ccfebd2
Show file tree

Hide file tree

Showing 10 changed files with 50 additions and 79 deletions.
diff --git a/.github/workflows/release.json b/.github/workflows/release.json
@@ -11,10 +11,10 @@
             "runs-on": "ubuntu-latest",
             "steps": [{
                 "name": "clone repository",
-                "uses": "actions/checkout@v3"
+                "uses": "actions/checkout@v4"
             }, {
                 "name": "dispatch release",
-                "uses": "softprops/action-gh-release@v1",
+                "uses": "softprops/action-gh-release@v2",
                 "with": {
                     "generate_release_notes": true
                 }

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -8,8 +8,8 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - name: clone repository
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: dispatch release
-              uses: softprops/action-gh-release@v1
+              uses: softprops/action-gh-release@v2
               with:
                 generate_release_notes: true
diff --git a/.github/workflows/test.json b/.github/workflows/test.json
@@ -31,47 +31,28 @@
                 "matrix": {
                     "board": [{
                         "vendor": "arduino",
-                        "arch": "samd",
-                        "name": "arduino_zero_native"
+                        "arch": "avr",
+                        "name": "uno"
                     }, {
-                        "vendor": "adafruit",
+                        "vendor": "arduino",
                         "arch": "samd",
-                        "name": "adafruit_trinket_m0"
-                    }, {
-                        "vendor": "STMicroelectronics",
-                        "arch": "stm32",
-                        "name": "GenH5"
+                        "name": "arduino_zero_native"
                     }, {
-                        "vendor": "teensy",
-                        "arch": "avr",
-                        "name": "teensy41"
+                        "vendor": "arduino",
+                        "arch": "renesas_uno",
+                        "name": "minima"
                     }],
                     "include": [{
                         "index": "https://downloads.arduino.cc/packages/package_index.json",
                         "board": {
                             "vendor": "arduino"
                         }
-                    }, {
-                        "index": "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json",
-                        "board": {
-                            "vendor": "adafruit"
-                        }
-                    }, {
-                        "index": "https://github.com/stm32duino/BoardManagerFiles/raw/main/package_stmicroelectronics_index.json",
-                        "board": {
-                            "vendor": "STMicroelectronics"
-                        }
-                    }, {
-                        "index": "https://www.pjrc.com/teensy/package_teensy_index.json",
-                        "board": {
-                            "vendor": "teensy"
-                        }
                     }]
                 }
             },
             "steps": [{
                 "name": "clone repository",
-                "uses": "actions/checkout@v3"
+                "uses": "actions/checkout@v4"
             }, {
                 "name": "install arduino and run test",
                 "uses": "arduino/compile-sketches@v1",

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -22,34 +22,22 @@ jobs:
             fail-fast: true
             matrix:
                 board:
+                    - vendor: arduino
+                      arch: avr
+                      name: uno
                     - vendor: arduino
                       arch: samd
                       name: arduino_zero_native
-                    - vendor: adafruit
-                      arch: samd
-                      name: adafruit_trinket_m0
-                    - vendor: STMicroelectronics
-                      arch: stm32
-                      name: GenH5
-                    - vendor: teensy
-                      arch: avr
-                      name: teensy41
+                    - vendor: arduino
+                      arch: renesas_uno
+                      name: minima
                 include:
                     - index: https://downloads.arduino.cc/packages/package_index.json
                       board:
                         vendor: arduino
-                    - index: https://adafruit.github.io/arduino-board-index/package_adafruit_index.json
-                      board:
-                        vendor: adafruit
-                    - index: https://github.com/stm32duino/BoardManagerFiles/raw/main/package_stmicroelectronics_index.json
-                      board:
-                        vendor: STMicroelectronics
-                    - index: https://www.pjrc.com/teensy/package_teensy_index.json
-                      board:
-                        vendor: teensy
         steps:
             - name: clone repository
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: install arduino and run test
               uses: arduino/compile-sketches@v1
               with:

diff --git a/LICENSE.md b/LICENSE.md
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2023 Kazuki Ota
+Copyright (c) 2024 Kazuki Ota
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/examples/decode/decode.ino b/examples/decode/decode.ino
@@ -1,6 +1,6 @@
 #include "arduino_percent.hpp"
 
-void setup(){
+void setup() {
     Serial.begin(115200);
     while(!Serial);
 
@@ -11,4 +11,6 @@ void setup(){
     Serial.println(output);
 }
 
-void loop(){}
+void loop() {
+    // nop
+}
diff --git a/examples/encode/encode.ino b/examples/encode/encode.ino
@@ -1,6 +1,6 @@
 #include "arduino_percent.hpp"
 
-void setup(){
+void setup() {
     Serial.begin(115200);
     while(!Serial);
 
@@ -11,4 +11,6 @@ void setup(){
     Serial.println(output);
 }
 
-void loop(){}
+void loop() {
+    // nop
+}
diff --git a/library.properties b/library.properties
@@ -1,6 +1,6 @@
 name=percent_encode
 author=dojyorin
-version=2.0.3
+version=2.0.4
 architectures=*
 includes=arduino_percent.hpp
 sentence=Convert between URL-unsafe string and percent encoded string.

diff --git a/src/arduino_percent.hpp b/src/arduino_percent.hpp
@@ -7,7 +7,7 @@
 * Convert between URL-unsafe string and percent encoded string.
 * @see https://github.com/dojyorin/arduino_percent
 */
-namespace percent{
+namespace percent {
     /**
     * Convert URL-unsafe string to percent encoded string.
     * @example

diff --git a/src/percent.cpp b/src/percent.cpp
@@ -1,26 +1,26 @@
 #include "./arduino_percent.hpp"
 
-namespace{
+namespace {
     constexpr char CODE[] = "0123456789ABCDEF";
     constexpr char UNRESERVED[] = "-._~0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
 
-    uint8_t indexOf(char search){
-        if('`' < search){
+    uint8_t indexOf(char search) {
+        if('`' < search) {
             search -= ' ';
         }
 
-        for(uint8_t i = 0; i < 16; i++){
-            if(::CODE[i] == search){
+        for(uint8_t i = 0; i < 16; i++) {
+            if(::CODE[i] == search) {
                 return i;
             }
         }
 
         return 0xFF;
     }
 
-    bool isUnreserved(char search){
-        for(const auto &v: ::UNRESERVED){
-            if(v == search){
+    bool isUnreserved(char search) {
+        for(const auto &v: ::UNRESERVED) {
+            if(v == search) {
                 return true;
             }
         }
@@ -29,12 +29,11 @@ namespace{
     }
 }
 
-void percent::encode(const char* input, char* output){
-    while(*input != '\0'){
-        if(::isUnreserved(*input)){
+void percent::encode(const char* input, char* output) {
+    while(*input != '\0') {
+        if(::isUnreserved(*input)) {
             *output++ = *input;
-        }
-        else{
+        } else {
             *output++ = '%';
             *output++ = ::CODE[*input >> 0x04];
             *output++ = ::CODE[*input & 0x0F];
@@ -46,22 +45,21 @@ void percent::encode(const char* input, char* output){
     *output = '\0';
 }
 
-size_t percent::encodeLength(const char* input){
+size_t percent::encodeLength(const char* input) {
     size_t length = 0;
 
-    while(*input != '\0'){
+    while(*input != '\0') {
         length += ::isUnreserved(*input++) ? 1 : 3;
     }
 
     return length + 1;
 }
 
-void percent::decode(const char* input, char* output){
-    while(*input != '\0'){
-        if(*input == '%'){
+void percent::decode(const char* input, char* output) {
+    while(*input != '\0') {
+        if(*input == '%') {
             *output++ = (::indexOf(*++input) << 4) + ::indexOf(*++input);
-        }
-        else{
+        } else {
             *output++ = *input;
         }
 
@@ -71,10 +69,10 @@ void percent::decode(const char* input, char* output){
     *output = '\0';
 }
 
-size_t percent::decodeLength(const char* input){
+size_t percent::decodeLength(const char* input) {
     size_t length = 0;
 
-    while(*input != '\0'){
+    while(*input != '\0') {
         input += *input == '%' ? 3 : 1;
         length++;
     }