-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(katana): support raw chain id #2276
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
- Coverage 70.29% 70.27% -0.02%
==========================================
Files 342 342
Lines 45094 45108 +14
==========================================
+ Hits 31698 31699 +1
- Misses 13396 13409 +13 ☔ View full report in Codecov by Sentry. |
@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now |
<3333 okk thx |
Description
This PR is made in other to provide a failing example for issue #1595.
Commit on blockifier which implemented the feature: dojoengine/sequencer@07f473f
Related issue
#1595
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit
New Features
cairo-vm-test-utils
for enhanced testing capabilities.GetChainId
to retrieve the chain ID within the StarkNet environment.Bug Fixes
Documentation
read_compiled_class_artifact
function to clarify its purpose.Chores
GetChainId
contract.