-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the build times of dyaml.node #314
base: master
Are you sure you want to change the base?
Conversation
What impact does this have on runtime? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
+ Coverage 95.20% 95.33% +0.12%
==========================================
Files 29 29
Lines 4569 4604 +35
==========================================
+ Hits 4350 4389 +39
+ Misses 219 215 -4
Continue to review full report at Codecov.
|
It's running in a module constructor, so it's a one-time additional cost. The benefit is in build times (at least with dub it helps speeds things up). |
Once-per-execution is more than once-per-compilation. This will increase the time it takes dub to start compiling. Have you factored that into your comparison? |
I haven't looked at the speed at which dub itself runs. I've only been looking at ways to get the 24s build time down (got it to 22s). Due to std.regex pulling in the Unicode tables which get built upon first use, this stuff isn't cheap and certainly can be done cheaper at runtime than compile time. |
Please look at that. Runtime costs are much more important than compilation costs. |
In an attempt to improve dub's build times.