Ubuntu 17.04 / CakePHP / Grunt w/SASS / Foundation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarrs
commented
Jun 2, 2017
•
rmarrs
commented
- returned to Ubuntu 16.04
- fixed php-fpm sock names for PHP7
- implemented Grunt SASS & Uglify for CakePHP
- added full foundation & foundation icons for CakePHP
- added Wordpress install to https://192.168.50.4:8084/
added 15 commits
May 24, 2017 14:59
Added CakePHP Fixed php-fpm.conf files across all platforms to name the socket php7-fpm.sock instead of php5-fpm.sock
Calls foundation on load grunt watch start
Update all roles to https added default Foundation script to webroot/js/custom.js remove the create_ssl.sh script after it runs
Still resolving rc-local issues
|
I really like this but I just don't understand why the upgrade to Ubuntu 17.04 is included here. I would keep such a change separated and in general I'd would like to support LTS versions only and 17.04 is none. |
|
You are correct, that shouldn't have been rolled up. I'll get that fixed and request another pull. |
exists. Allows a vagrant destroy / vagrant up refresh rolled back Ubuntu to 16.04
upgraded packages, etc
|
I've downgraded back to 16.04, and added a Wordpress installation to port 8084. |
|
As this issue is quite old, I'd like to know if this PR will ever land. Otherwise, may I suggest moving forward to v20.04, as suggested in issue #42? I would really like to see this dev-box advance 🦊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.