Change HKDF-CTR to HKDF #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to w3c/webcrypto#193 (comment), it's actually good that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the HKDF-CTR algorithm, which was removed from webcrypto, in favor of HKDF.
There are two changes: one for the documentations in
README.mdand the other for the live table tester table.Test Plan
This was tested against Chrome 67.0.3396.79. All implementations pass correctly.
This was also tested against Firefox 60, however it seems to be throwing a
An invalid or illegal string was specifiedexception onderiveKey, whilederiveBitssucceeds. I am unsure if the issue is my implementation or an issue with Firefox.Fixes #46