Add smart row wrapping and cleanup table drawing #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two features improving the handling of null/not drawn borders I needed since I use boxable for layout.
It makes page wrapping a bit smarter. This prevents page breaks at visually wrong locations with null borders.
The rows that are allowed to be wrapped to the next page can be customized using an interface similar to the one for word wrapping.
Additionally, I cleaned up the logic for top border removal, and made it only remove the next top border, if the previous bottom border exists. This e.g. allows you to use borderless rows as separator between tables, without making those tables lose their top borders.
This is very basic and could be improved further, allowing conflicting border styles and partial borders to be handled better.