Skip to content

Commit

Permalink
Fix contrast on non-darkmode notebooks
Browse files Browse the repository at this point in the history
  • Loading branch information
dgunning committed Nov 14, 2024
1 parent 532ede5 commit 395a940
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
10 changes: 5 additions & 5 deletions edgar/xbrl/xbrldata.py
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ def __rich__(self):
title=Text.assemble(
(f"{self.entity}\n", "bold deep_sky_blue2"),
(f"{self.display_name}\n", "bold"),
(f"{self.display_duration.title()}", "italic grey74")
(f"{self.display_duration.title()}", "italic grey60")
),
box=box.SIMPLE,
padding=(0, 1),
Expand Down Expand Up @@ -1193,14 +1193,14 @@ def __rich__(self):
label_style = "bold deep_sky_blue3"
value_style = "bold white"
elif style == 'Subsection':
label_style = "italic grey74"
value_style = "italic grey74"
label_style = "italic grey60"
value_style = "italic grey60"
elif style == 'Total':
label_style = "bold deep_sky_blue3"
value_style = "bold deep_sky_blue3"
else:
label_style = "white"
value_style = ""
label_style = "grey42"
value_style = "grey42"

# Format label with indentation
indent = " " * row.get('level', 0)
Expand Down
7 changes: 2 additions & 5 deletions tests/test_xbrl_financials.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ async def test_labels_for_orcl_10K(orcl_xbrl):
balance_sheet = financials.get_balance_sheet()
labels = balance_sheet.data.index.tolist()
assert all([not label.startswith('us-gaap_') for label in labels])
repr_ = repr(balance_sheet)
assert repr_


@pytest.mark.asyncio
Expand Down Expand Up @@ -226,11 +228,6 @@ def test_query_facts_with_empty_dimensions(apple_xbrl):
assert all([col not in instance.dimension_columns for col in facts.columns])


def test_xbrl_instance_dimensions(apple_xbrl):
instance: XBRLInstance = apple_xbrl.instance
print(instance.dimensions)


def test_xbrl_presentation_role_with_almost_duplicate_name(apple_xbrl):
statement = apple_xbrl.statements.get('RevenueDeferredRevenueExpectedTimingofRealizationDetails_1')
assert statement is None
Expand Down

0 comments on commit 395a940

Please sign in to comment.