2 Node 2 Upgrade #375
Open
2 Node 2 Upgrade #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily `process.EventEmitter.prototype` doesn't work and we need to
`require('EventEmitter')` instead. So this line has been adjusted:
https://github.com/mafintosh/curly/blob/568c6359906dd26d58f69c4dde8c327d0b56f4ac/index.js#L51
Pulled from hubot-test-helper examples
The voting timeout test still fails 😕
This comment was marked as spam.
This comment was marked as spam.
|
Confirmation AYP seems to work locally: You can see me fuckin with voting to manually boop some shit. |
Additionally, this lock seems to function in vagrant so all is well I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How hard could this be? Probably very. But I can put forth some effort I suppose.
Targets #319
So far:
curlyto work with newer Node. This is a dependency ofnode-s3, so a better path would be to replace that entirely.My currentwaitForReplyapproach is hella sus and I don't even think fully resolving this, so I need to revisit this.coas per examples in hubot-test-helper. Still need to get the voting timeout test to pass though.DEBUG=1mode