isolating 21a sub app #33262
Open
isolating 21a sub app #33262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chumpy
added
the
benefits-accredited-rep-facing
va-vfs-bot
reviewed
Nov 27, 2024
| className="header-us-flag vads-u-margin-right--1" | ||
| src="https://www.va.gov/img/tiny-usa-flag.png" | ||
| /> | ||
| {/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */} |
| /> | ||
|
|
||
| <p>An official website of the United States government</p> | ||
| {/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component, react/button-has-type */} |
| } else if (profile) { | ||
| content = ( | ||
| <div className="va-dropdown" ref={dropdownRef}> | ||
| {/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
department-of-veterans-affairs/va.gov-team#96895
Step 1 of react-router upgrade is to fully isolate the 21a app from any libraries upgraded in the
accredited-representative-portalapplication found in a parent directory.The approach is to copy components shared from the parent application into the 21a application so that we can preserve any functionality affected by the upgrade to the parent application. We also are creating a workspace with a localized
package.jsonfile that will ensure we stay on the current version of react-router when we upgrade the parent application.