Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust spacing for definition list elements in Survivor Benefit #33227

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bradbergeron-us
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Updates Styling and accessibility findings for Survivorship Application bank information review page within the form flow.

Related issue(s)

Screenshot 2024-11-25 at 3 21 00 PM https://github.com/department-of-veterans-affairs/va.gov-team/issues/96655

Testing done

Screenshots

Screenshot 2024-11-25 at 3 16 48 PM

What areas of the site does it impact?

5490 Survivor Benefit Bank Information Review Page

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@bradbergeron-us bradbergeron-us marked this pull request as ready for review November 25, 2024 20:27
@bradbergeron-us bradbergeron-us requested review from a team as code owners November 25, 2024 20:27
s-caso
s-caso previously approved these changes Nov 25, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/SA-101486-5490-definition-list-updates/main November 25, 2024 23:51 Inactive
rsmithadhoc
rsmithadhoc previously approved these changes Nov 26, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/SA-101486-5490-definition-list-updates/main November 27, 2024 16:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/SA-101486-5490-definition-list-updates/main November 27, 2024 18:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants