-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authed patterns/aw/vadx panel discovery 1 #33216
Authed patterns/aw/vadx panel discovery 1 #33216
Conversation
… comment consistency
…nd broadcast channel woes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
src/applications/_mock-form-ae-design-patterns/vadx/panel/VADXPanelLoader.jsx
Show resolved
Hide resolved
src/applications/_mock-form-ae-design-patterns/vadx/panel/tabs/TogglesTab.jsx
Show resolved
Hide resolved
src/applications/_mock-form-ae-design-patterns/vadx/utils/StorageAdapter.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
src/applications/_mock-form-ae-design-patterns/vadx/panel/FloatingButton.jsx
Show resolved
Hide resolved
src/applications/_mock-form-ae-design-patterns/vadx/panel/HeadingHierarchyInspector.jsx
Show resolved
Hide resolved
src/applications/_mock-form-ae-design-patterns/vadx/panel/tabs/OtherTab.jsx
Show resolved
Hide resolved
src/applications/_mock-form-ae-design-patterns/vadx/panel/tabs/TogglesTab.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Very thorough unit test for the Storage Adapter too.
Approved.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
aedp_vadx
toggle is trueRelated issue(s)
Testing done
Screenshots
No before screenshots because this is new work.
TOGGLES TAB
FORM TAB
OTHER TAB
CUSTOM TAB - TESTED WITH A FEW CUSTOM LINKS FOR THE AEDP APP
What areas of the site does it impact?
Only the mock AE design patterns app currently. The idea would be to provide to a wider audience, but need to prove out the concept first.
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication