Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authed patterns/aw/vadx panel discovery 1 #33216

Merged
merged 20 commits into from
Nov 27, 2024

Conversation

adamwhitlock1
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 commented Nov 25, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds a set of tools to allow debugging of feature toggles, view form routes, and access some basic a11y tools
  • Feature toggle tab allows local manipulation of feature toggles
  • Form tab shows form routes and allows navigation between pages and skipping pages
  • Other tab includes heading hierarchy analyzer and focus element debugger
  • Optional tab can be provided by the application using the tool to provide a set of application specific tools
  • Tool is only rendered in local environments when the aedp_vadx toggle is true
  • This is a MVP to evaluate further development of features

Related issue(s)

Testing done

  • Added unit tests for storage adapter
  • Used local environment to verify functionality
  • More tests for core hooks and service utils coming soon

Screenshots

No before screenshots because this is new work.

TOGGLES TAB
Screenshot 2024-11-26 at 8 43 43 PM

FORM TAB
Screenshot 2024-11-26 at 8 43 52 PM

OTHER TAB
Screenshot 2024-11-26 at 8 44 09 PM

CUSTOM TAB - TESTED WITH A FEW CUSTOM LINKS FOR THE AEDP APP
Screenshot 2024-11-26 at 8 44 17 PM

What areas of the site does it impact?

Only the mock AE design patterns app currently. The idea would be to provide to a wider audience, but need to prove out the concept first.

Acceptance criteria

  • Panel MVP created, will be followed up with discovery doc around this work.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/authed-patterns/aw/vadx-panel-discovery-1/main November 26, 2024 01:54 Inactive
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Very thorough unit test for the Storage Adapter too.
Approved.

@adamwhitlock1 adamwhitlock1 merged commit e116994 into main Nov 27, 2024
70 of 71 checks passed
@adamwhitlock1 adamwhitlock1 deleted the authed-patterns/aw/vadx-panel-discovery-1 branch November 27, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants