-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHV-64147: Blue Button reducer implemented #33205
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two overall comments:
- Write some tests for these conversion functions.
- Breaking some of the bigger ones (e.g. demographics) into smaller functions might make it easier to test some functionality, but I'll leave that up to you.
homePhone: 'None recorded', | ||
workPhone: 'None recorded', | ||
cellPhone: 'None recorded', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we assuming no data provided for these values as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maruf said the user he gave me had all fields so I am assuming there is no data for these. You, him, perhaps Lexi, and I should meet to double check about this.
Summary
Created a reducer for the following Blue Button data:
Added mock data endpoints for all of the above data
Related issue(s)
https://jira.devops.va.gov/browse/MHV-64147
Testing done
none yet
Screenshots
No UI changes
What areas of the site does it impact?
MHV medical records
Acceptance criteria
Blue Button reducer implemented, working, and formatting data for Blue Button report
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback