Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-64147: Blue Button reducer implemented #33205

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mattwrightva
Copy link
Contributor

@mattwrightva mattwrightva commented Nov 23, 2024

Summary

Created a reducer for the following Blue Button data:

  • medications
  • appointments
  • demographics
  • military service
  • account summary (treatment facilities)

Added mock data endpoints for all of the above data

Related issue(s)

https://jira.devops.va.gov/browse/MHV-64147

Create reducer for remaining BB download domains

Description
Work w/ Mike for data mapping questions.

This includes ALL data that we aren't currently pulling for BB download, including medications, appts, demographics, etc.

Testing done

none yet

Screenshots

No UI changes

What areas of the site does it impact?

MHV medical records

Acceptance criteria

Blue Button reducer implemented, working, and formatting data for Blue Button report

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Copy link
Contributor

@mmoyer-va mmoyer-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two overall comments:

  1. Write some tests for these conversion functions.
  2. Breaking some of the bigger ones (e.g. demographics) into smaller functions might make it easier to test some functionality, but I'll leave that up to you.

Comment on lines 145 to 147
homePhone: 'None recorded',
workPhone: 'None recorded',
cellPhone: 'None recorded',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we assuming no data provided for these values as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maruf said the user he gave me had all fields so I am assuming there is no data for these. You, him, perhaps Lexi, and I should meet to double check about this.

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-64147-bb-download-reducer/main November 25, 2024 20:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-64147-bb-download-reducer/main November 26, 2024 01:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants