Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19826 - new Operating Statuses on nearby Vet centers and satellite #33197

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Nov 22, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Changes the VetCenterInfo and OperationStatus component's to use the new operating status codes and color/icon schemes

Related issue(s)

Testing done

  • Manually tested with data coming back from sandbox-api LH and updated components

Screenshots

Satellite locations coming back as Limited Screenshot 2024-11-22 at 12 54 49 PM
Other nearby with closed and limited statuses Screenshot 2024-11-22 at 12 52 30 PM

What areas of the site does it impact?

Vet Center locations pages currently

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check in RI on /charlotte-vet-center/locations/
/greensboro-vet-center/locations/

@eselkin eselkin marked this pull request as ready for review November 22, 2024 21:26
@eselkin eselkin requested review from a team as code owners November 22, 2024 21:26
@eselkin eselkin changed the title VACMS 19826 - working nearby Vet centers and satellite VACMS 19826 - new Operating Statuses on nearby Vet centers and satellite Nov 22, 2024
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants