Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few page details #33191

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

juancstlm-a6
Copy link
Contributor

@juancstlm-a6 juancstlm-a6 commented Nov 22, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Moved validation to the onSubmit function
  • Added the a va-telephone component to render the provider.orgPhone
  • Restore and save selected date for the referral so that it persist a reload
  • use existing VAOS functions to get the timezone based on referral
  • use existing VAOS date format function to display the timezone information.

Related issue(s)

Testing done

  • Schedule referral date and time would not persist the selected date and time for the referral
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Screen Shot 2024-11-22 at 11 35 42 Screen Shot 2024-11-22 at 11 18 52
Desktop Screenshot 2024-11-22 at 11-35-54 VA Online Scheduling Veterans Affairs Screenshot 2024-11-22 at 11-18-43 VA Online Scheduling Veterans Affairs
Kapture.2024-11-22.at.11.21.58.mp4

What areas of the site does it impact?

  • VAOS

Acceptance criteria

  • Selected date validation should happen after clicking to continue
  • Telephone number should be clickable with href=://tel:
  • Store selected date keyed on referral UUID in session to restore on refresh
  • Restore selected date from session on reload
  • Time zone should be based off of referring facility
  • Use existing VAOS TZ formatters

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@juancstlm-a6 juancstlm-a6 linked an issue Nov 22, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix a few page details
1 participant