Sa 101518 5490 dup contact info modal (#32860)

* add dup email/phone to state * fix your info review section * fix submit transform * mocked dupe contact response
department-of-veterans-affairs · Nov 2, 2024 · 5921e81 · 5921e81
1 parent f067f50
commit 5921e81
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 13 deletions.
diff --git a/...urvivor-dependent-education-benefit/22-5490/components/PersonalInformationReviewField.jsx b/...urvivor-dependent-education-benefit/22-5490/components/PersonalInformationReviewField.jsx
@@ -29,18 +29,18 @@ const PersonalInformationReviewField = ({
   userFullName,
 }) => {
   const formattedDateOfBirth = formatDateString(dateOfBirth);
-
   return (
     <>
       <div className="form-review-panel-page">
-        <button
-          aria-label={`Edit ${title}`}
-          className="edit-btn primary-outline"
-          onClick={editPage}
-          type="button"
-        >
-          Edit
-        </button>
+        <div className="form-review-panel-page-header-row">
+          <va-button
+            aria-label={`Edit ${title}`}
+            secondary
+            text="Edit"
+            onClick={editPage}
+          />
+        </div>
+
         <dl className="review">
           <div className="review-row">
             <p className="va-address-block">

diff --git a/src/applications/survivor-dependent-education-benefit/22-5490/containers/App.jsx b/src/applications/survivor-dependent-education-benefit/22-5490/containers/App.jsx
@@ -78,8 +78,7 @@ function App({
       }
 
       if (
-        formData?.mobilePhone?.phone &&
-        formData?.email &&
+        (formData?.mobilePhone?.phone || formData?.email) &&
         !formData?.duplicateEmail &&
         !formData?.duplicatePhone
       ) {

diff --git a/src/applications/survivor-dependent-education-benefit/22-5490/selectors.js b/src/applications/survivor-dependent-education-benefit/22-5490/selectors.js
@@ -8,6 +8,8 @@ export const getAppData = state => ({
   formId: state?.form?.formId,
   isPersonalInfoFetchComplete: state.data?.personalInfoFetchComplete,
   isSponsorsFetchComplete: state.data?.fetchedSponsorsComplete,
+  duplicateEmail: state.data?.duplicateEmail,
+  duplicatePhone: state.data?.duplicatePhone,
   isLOA1: isLOA1Selector(state),
   isLOA3: isLOA3Selector(state),
   savedForms: state?.user?.profile?.savedForms,

diff --git a/.../survivor-dependent-education-benefit/22-5490/tests/fixtures/data/duplicateContactInfo.js b/.../survivor-dependent-education-benefit/22-5490/tests/fixtures/data/duplicateContactInfo.js
@@ -0,0 +1,10 @@
+export const dupContactInfoReponse = {
+  data: {
+    id: '',
+    type: 'meb_api_dgi_dup_contact_responses',
+    attributes: {
+      email: [{ value: '[email protected]', dupe: true }],
+      phone: [{ value: '8013090123', dupe: true }],
+    },
+  },
+};
diff --git a/src/applications/survivor-dependent-education-benefit/22-5490/utils/form-submit-transform.js b/src/applications/survivor-dependent-education-benefit/22-5490/utils/form-submit-transform.js
@@ -348,14 +348,14 @@ export function transform5490Form(_formConfig, form) {
         addressLine2: form?.data?.mailingAddressInput?.address?.street2,
         city: form?.data?.mailingAddressInput?.address?.city,
         zipcode: form?.data?.mailingAddressInput?.address?.postalCode,
-        emailAddress: form?.data?.email?.email,
+        emailAddress: form?.data?.email,
         addressType: getAddressType(form?.data?.mailingAddressInput),
         mobilePhoneNumber: form?.data?.mobilePhone?.phone,
         homePhoneNumber: form?.data?.homePhone?.phone,
         countryCode: getLTSCountryCode(
           form?.data?.mailingAddressInput?.address?.country,
         ),
-        stateCode: form?.data?.mailingAddressInput?.state,
+        stateCode: form?.data?.mailingAddressInput?.address?.state,
       },
       preferredContact: form?.data?.contactMethod,
     },