Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to twox-hash 2.0 #937

Closed
wants to merge 1 commit into from

Conversation

shepmaster
Copy link

Thanks for using my crate!

Note that version 2.0 increases the MSRV to Rust 1.81. I understand if you don't want to upgrade right away, but hopefully this PR will be useful when you do.

I'm opening these PRs for the top users of twox-hash and have no current plans to become a consistent contributor to this specific repository; please feel free to rewrite the commit as appropriate for your project's requirements.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (0c7f83e) to head (cf7caa8).
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   81.43%   81.45%   +0.01%     
==========================================
  Files          97       97              
  Lines       23877    24930    +1053     
==========================================
+ Hits        19445    20307     +862     
- Misses       4432     4623     +191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartlomieju
Copy link
Member

Thanks @shepmaster, can you please sign the CLA so we can land this PR?

@shepmaster
Copy link
Author

can you please sign the CLA

Thank you, but I don't have the drive to become a contributor, much less spend any time thinking about signing a legal document to do so. You are welcome to take this PR however you like, including closing it. Another project with a CLA found a solution.

Have a great day!

@bartlomieju
Copy link
Member

No worries, I understand your position. I opened #939 so you don't have to sign a CLA, thanks for highlighting this and working on twox-hash!

bartlomieju added a commit that referenced this pull request Oct 22, 2024
@shepmaster shepmaster deleted the twox-hash-bump branch October 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants