Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decrediton-setup.md #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fintechtrades
Copy link

Additional information for restoring wallet from file

Additional information for restoring wallet from file
Copy link
Contributor

@matthawkins90 matthawkins90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi fintechtrades, I saw your thread in DCR Support on matrix. Thanks for taking the time to help improve the docs based on your experience.

I have a few in-line comments and suggestions for how to make this flow better with the rest of the document.

@@ -130,3 +130,15 @@ Press **Create Wallet** and your wallet setup is complete. You will be taken bac
1. Select **Create Wallet**. Wait for the blockchain to be downloaded.
Copy link
Contributor

@matthawkins90 matthawkins90 Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below line 116, add a new line and the subheader:

### Restore Wallet From Seed Phrase

@@ -130,3 +130,15 @@ Press **Create Wallet** and your wallet setup is complete. You will be taken bac
1. Select **Create Wallet**. Wait for the blockchain to be downloaded.

1. The blockchain will now be scanned for any transactions belonging to this wallet.

## Restore Existing Wallet from file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to subheader

### Restore Wallet From File

## Restore Existing Wallet from file

Decred wallet file locations are:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Windows: C:\Users\{Username}\AppData\Local\Decrediton\wallets\mainnet\{walletname}
  • macOS: ~/Library/Application Support/decrediton/wallets/mainnet/{walletname}
  • Linux: ~/.config/decrediton/wallets/mainnet/{walletname}

Copy link
Contributor

@dezryth dezryth Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to making these bullet points, I suggest using %USERNAME% instead of {Username} for Windows as that is a common environment variable that any windows user can copy and paste into the path bar.

Also I believe it is more common to use <> to clarify that is where a user needs to provide their own text, so you may want to use <wallet name>


Mac: ~/Library/Application Support/decrediton/wallets/mainnet/

In order to restore a wallet from file, you can copy and paste the wallet folder to the new computer.
Copy link
Contributor

@matthawkins90 matthawkins90 Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing the wording to the following:
(I believe the recommended line-length is 80 char)

To restore a wallet from a file, it's possible to copy and paste the old wallet
folder to the new computer.

However, if you are restoring a wallet which was created on a different
operating system, the config file `dcrwallet.conf` will be incorrect.

To remedy this:

1. Using Decrediton, create a new wallet to populate the correct config files.

1. Close Decrediton.

1. Copy your previous `wallet.db` file and replace it into the new wallet's
mainnet folder: `.../decrediton/wallets/mainnet/{walletname}/mainnet/wallet.db`

1. Review the new `dcrwallet.conf` to check that the settings are correct.

1. Open Decrediton to see your wallet restored.

@fintechtrades
Copy link
Author

Hi fintechtrades, I saw your thread in DCR Support on matrix. Thanks for taking the time to help improve the docs based on your experience.

I have a few in-line comments and suggestions for how to make this flow better with the rest of the document.

I appreciate you taking time to make the corrections. This is my first time using github but I am looking forward to contributing to the decred repo with little things like this.

@xaur
Copy link

xaur commented Mar 3, 2021

Welcome @fintechtrades !

Mind that what people have suggested are not corrections, you would need to address the comments with further edits before this can be merged (unless repository maintainers decide to merge it as is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants