Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow DateTimeOffset to date claims #136

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

grosch
Copy link
Contributor

@grosch grosch commented Jul 12, 2024

Adds the ability to pass a DateTimeOffset to the date related claims. Closes #135

@daviddesmet daviddesmet added the enhancement New feature or request label Jul 13, 2024
Copy link
Owner

@daviddesmet daviddesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking care of adding DateTimeOffset and for refactoring the tests!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (a9672cc) to head (c802d3f).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Paseto/Builder/PasetoBuilderExtensions.cs 50.00% 7 Missing ⚠️
src/Paseto/Validators/DateValidator.cs 65.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   90.31%   90.22%   -0.09%     
==========================================
  Files         104      104              
  Lines        5099     5105       +6     
  Branches      329      330       +1     
==========================================
+ Hits         4605     4606       +1     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daviddesmet daviddesmet merged commit 505cd30 into daviddesmet:master Jul 14, 2024
7 checks passed
@daviddesmet daviddesmet added the minor Requiring a minor version update according to semantic versioning label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Requiring a minor version update according to semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add DateTimeOffset overloads
3 participants