Handle timestamp in go/VERSION #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `go1.21.0.src.tar.gz` contains a go/VERSION file with the following
contents:
go1.21.0
time 2023-08-04T20:14:06Z
The added timestamp wasn't handled well by the parser of that file. This
commit adds a regexp that correctly parses the version from the content.
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added a commit
to telepresenceio/telepresence
that referenced
this pull request
Aug 15, 2023
Updates the go-mkopensource tool to this PR: datawire/go-mkopensource#61 Signed-off-by: Thomas Hallgren <[email protected]>
njayp
approved these changes
Aug 15, 2023
knlambert
requested review from
a team and
josecv
and removed request for
a team
thallgren
added a commit
to telepresenceio/telepresence
that referenced
this pull request
Aug 21, 2023
Updates the go-mkopensource tool to this PR: datawire/go-mkopensource#61 Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added a commit
to telepresenceio/telepresence
that referenced
this pull request
Aug 23, 2023
Updates the go-mkopensource tool to this PR: datawire/go-mkopensource#61 Signed-off-by: Thomas Hallgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
go1.21.0.src.tar.gzcontains a go/VERSION file with the following contents:The added timestamp wasn't handled well by the parser of that file. This commit adds a regexp that correctly parses the version from the content.