Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): option to not create clusterRoles; #172

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

mariuskimmina
Copy link
Contributor

Related to #170 and #162

When destroying and re-creating the operator (for example when moving to another namespace) we want to keep CRDs and ClusterRoles around. This PR adds an option createClusterRoles to the helm chart which can be used to re-create the operator without re-creating the ClusterRoles, which would currently fail.
The default value is true and thus default behavior of the chart will not change.

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.

@mariuskimmina
Copy link
Contributor Author

Any thoughts @AdheipSingh ?

@mariuskimmina
Copy link
Contributor Author

Hey @AdheipSingh we'd really love to see a new release with this and #162 (already merged) included. Let me know if you have any concerns.

@AdheipSingh AdheipSingh merged commit d9e0f6e into datainfrahq:master Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants