Allow concurrent TCP clients #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default logging of packets using "{:?}" looks like b"\xaa\xbb",
which is ugly and difficult to use. This logs the packets in hex
format instead using the faster-hex crate for the conversion to hex.
Signed-off-by: Daniel Estévez <[email protected]>
Previously, the CLI application accepted TCP clients one by one. The data from the second TCP client wasn't processed until the first TCP client had closed the connection or dvb-gse had closed the connection due to an error (such as a BBFRAME format error). This can give problems with clients that make a connection, then stop using that connection but keep it lingering somehow, and initiate a second connection and start attempting to transfer data over the second connection. Signed-off-by: Daniel Estévez <[email protected]>
This fixes some clippy lints in the tests and updates the CI workflow to use --all-targets with clippy, error out on doc failures, and use checkout@v4. Signed-off-by: Daniel Estévez <[email protected]>
Also update dependencies. Signed-off-by: Daniel Estévez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling of concurrent clients with
--input TCP, by spawning one thread per client and using an additional thread for the TUN device.