Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted behavior with parent filters #20

Open
wants to merge 8 commits into
base: 0.6-maintenance
Choose a base branch
from

Conversation

KROT47
Copy link

@KROT47 KROT47 commented Oct 9, 2024

Saw some unwanted behavior when we have some parent with specific filters like:

[{
  category: "my-app",
  sinks: ["a"],
}, {
  category: ["my-app", "with_level_with_filters"],
  level: "info",
  filters: ["someSpecificFilter"],
}, {
  category: ["my-app", "with_level_with_filters", "no_level_no_filters"],
}]

before this PR if we log to ["my-app", "with_level_with_filters", "no_level_no_filters"] then someSpecificFilter will be applied but it seems unobvious since if I just add any level to last config then someSpecificFilter won't be applied, e.g.

{
  category: ["my-app", "with_level_with_filters", "no_level_no_filters"],
  level: "info",
}

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (ebc4eb1) to head (645ebe6).

Additional details and impacted files
@@               Coverage Diff                @@
##           0.6-maintenance      #20   +/-   ##
================================================
  Coverage            97.24%   97.25%           
================================================
  Files                   10       10           
  Lines                 1018     1019    +1     
  Branches               217      217           
================================================
+ Hits                   990      991    +1     
  Misses                  28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response. I think this is a bug, so could you change the target branch from main to 0.6-maintenance?

@KROT47 KROT47 changed the base branch from main to 0.6-maintenance October 11, 2024 07:19
@dahlia
Copy link
Owner

dahlia commented Oct 11, 2024

Some unwanted commits seem included. Could you rebase it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants