-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unwanted behavior with parent filters #20
base: 0.6-maintenance
Are you sure you want to change the base?
Conversation
[ci skip]
LogTape 0.6.1
LogTape 0.6.2
LogTape 0.6.3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.6-maintenance #20 +/- ##
================================================
Coverage 97.24% 97.25%
================================================
Files 10 10
Lines 1018 1019 +1
Branches 217 217
================================================
+ Hits 990 991 +1
Misses 28 28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late response. I think this is a bug, so could you change the target branch from main to 0.6-maintenance?
Some unwanted commits seem included. Could you rebase it? |
Saw some unwanted behavior when we have some parent with specific filters like:
before this PR if we log to
["my-app", "with_level_with_filters", "no_level_no_filters"]
thensomeSpecificFilter
will be applied but it seems unobvious since if I just add any level to last config thensomeSpecificFilter
won't be applied, e.g.