Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ply-compatible float64 types #323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ply-compatible float64 types #323

wants to merge 4 commits into from

Commits on Jan 13, 2022

  1. map numpy built-in types into ply-compatible types

    @Tofull
    Tofull committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    08ee8c9 View commit details
    Browse the repository at this point in the history

  2. make float32 conversion optional

    @Tofull
    Tofull committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    199e29a View commit details
    Browse the repository at this point in the history

  3. try downcasting columns if dtype isn't natively PLY compatible 

    This makes columns like `voxel_n` (int_64) being downcasted to the smallest numerical dtype possible.
With the data used in tests/integration/test_core_class.py::test_split_on, this column can be downcasted to int8, which is ply compatible.
    @Tofull
    Tofull committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    0ea784e View commit details
    Browse the repository at this point in the history

  4. fix most of flake8 issues

    @Tofull
    Tofull committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    f3b2cb1 View commit details
    Browse the repository at this point in the history