Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra args to collate to handle edge cases [WIP] #302

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bethac07
Copy link
Member

@bethac07 bethac07 commented Jun 29, 2023

Description

Collate handles the standard cases pretty well at this point, but there are a number of edge cases I've been writing extra code in my own fork to handle; it would be nice to add first-class support

What is the nature of your change?

  • Enhancement (adds functionality).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

Codecov Report

Merging #302 (d4147cd) into master (7320516) will decrease coverage by 0.98%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   95.12%   94.14%   -0.98%     
==========================================
  Files          57       57              
  Lines        3057     3092      +35     
==========================================
+ Hits         2908     2911       +3     
- Misses        149      181      +32     
Flag Coverage Δ
unittests 94.14% <7.69%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pycytominer/cyto_utils/collate_cmd.py 0.00% <0.00%> (ø)
pycytominer/cyto_utils/collate.py 43.65% <8.57%> (-11.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d33bs
Copy link
Member

d33bs commented Aug 18, 2023

Hello, this is a courtesy notice that Pcytominer's master branch has been renamed to main as part of changes merged in #303. While changes here should be seamless, GitHub is unable to change your local git environment and offers the following guidance when it comes to this. Thank you for your understanding and please don't hesitate to reach out with any questions or concerns.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants