-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a button for Deployment/Statefulset logs #348
Conversation
Hey @doncicuto, sorry for the delay. Can we somehow move the Could you maybe move the manifest button in each component so we can add |
Hi @petar-cvit I'll try to update the PR following your requirements. Thanks! |
Hi @petar-cvit, I think the button issue is fixed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @doncicuto, looks good. I just left one comment on the component organization. Also, we merged one other PR so you will have to resolve some conflicts
<Button | ||
onClick={function () { | ||
fetchManifest( | ||
resource.group, | ||
resource.version, | ||
resource.kind, | ||
resource.namespace, | ||
resource.name, | ||
); | ||
}} | ||
> | ||
View Manifest | ||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this button to specific resource components? The only reason why I would do it is so because we don't have one row implemented in different components
Hi @petar-cvit, no problem, so you want me to move the Manifest button to all components found in the k8s-resources folder? |
yeah, that way we can add/remove buttons depending on the kind. I suppose it's not going to be a lot of copy pasted code if we extract those buttons into separate components and reuse them in k8s resources components |
@doncicuto, any updates on the PR? |
I'm deeply sorry Petar I've been pretty busy these months and I don't think I can resume my collaboration right now so to be honest it's better to unassign this issue to me. I like the project so I Will definitely help again on the future as soon as I get more free time. |
@doncicuto no worries, I will close this one then |
closes #257
π Description
This PR adds a button to show deployment and statefulset logs in the UI. Here are a couple of screenshots.
β Checks
Additional context
I've updated the handler.go to re-enable the endpoints required for this PR: