Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several figures seem to be wrong #419

Open
Fryie opened this issue Jun 24, 2021 · 1 comment
Open

Several figures seem to be wrong #419

Fryie opened this issue Jun 24, 2021 · 1 comment

Comments

@Fryie
Copy link

Fryie commented Jun 24, 2021

I suspect something got mixed up here, but when reading certain section it looks as if the wrong figures have been included. Here are some examples:

  • Figure 6.1 and 6.2 on pages 30-31 have nothing to do with permutations
  • The (unnumbered) figure on page 48 doesn't seem to refer to CBC

There might be others like that.

The way it is right now, the text is rather confusing.

Edit: I did some manual bisecting and this is the first release that seems to introduce these issues: https://github.com/crypto101/book/releases/tag/untagged-3d1e8824844fd9d69ab8
The figures look right in the previous release. Maybe something got mixed up when switching to sphinx.

@abetaev
Copy link

abetaev commented Mar 15, 2022

i have met the same issue, while was trying to make sense of those pictures
doesn't seem like this project is breathing with life though:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants