Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted figure replacement in the PDF release #436

Open
ysard opened this issue Mar 29, 2023 · 2 comments
Open

Unwanted figure replacement in the PDF release #436

ysard opened this issue Mar 29, 2023 · 2 comments

Comments

@ysard
Copy link

ysard commented Mar 29, 2023

Hello, when comparing with an old version I spotted a missing/replaced figure.

Old release used:
hash 0be019a: 0.6.0-3-g0be019a
New release used (the last one):
hash ddf2987: 0.6.0-115-gddf2987

In the PDF, OAEP chapter, the figure Illustrations/OAEP/Diagram.svg is replaced by the figure Illustrations/Dual_EC_DRBG/Diagram.svg.

The figure Dual_EC_DRBG is present a second time in the right place.

Yet the figure code seems correct, and the ReST code seems to be ok:

https://github.com/crypto101/book/blame/a39b3fc7bd53f5eff311a17ff3598dc540772409/src/random-number-generators.rst#L277

https://github.com/crypto101/book/blame/a39b3fc7bd53f5eff311a17ff3598dc540772409/src/public-key-encryption.rst#L199

This seems to be related to other reports like : #419
It may be a TeX layout issue...

Also I think that reading was easier with the old version (smaller margins so more text per line and nicer font) ;)

Thank you for this huge work!

@ysard
Copy link
Author

ysard commented Mar 29, 2023

I add another remark.
For figures like:
https://github.com/crypto101/book/blame/a39b3fc7bd53f5eff311a17ff3598dc540772409/src/message-authentication-codes.rst#L325
The figure was just below the sentence Visually, HMAC looks like this: but now in the PDF it's placed in the middle of the next paragraph.
There should be a way to fix the position of a figure in the text.

@reallifeinulas
Copy link

first fix the "cookie manager" error my friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants