cherry-pick pr 329 (#338)

Signed-off-by: wangyike <[email protected]>
crossplane · May 28, 2021 · 276c8c5 · 276c8c5
1 parent 933e0f3
commit 276c8c5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -42,7 +42,7 @@ linters-settings:
 
   gocyclo:
     # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    min-complexity: 15
+    min-complexity: 17
 
   maligned:
     # print struct with more effective memory layout or not, false by default

diff --git a/pkg/controller/v1alpha2/applicationconfiguration/apply.go b/pkg/controller/v1alpha2/applicationconfiguration/apply.go
@@ -84,6 +84,9 @@ type workloads struct {
 }
 
 func (a *workloads) Apply(ctx context.Context, status []v1alpha2.WorkloadStatus, w []Workload, ao ...resource.ApplyOption) error {
+	if len(w) == 0 {
+		return errors.New("The number of workloads in appConfig is 0")
+	}
 	// they are all in the same namespace
 	var namespace = w[0].Workload.GetNamespace()
 	for _, wl := range w {