Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parameterize prometheus scrape annotation #28

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: Parameterize prometheus scrape annotation #28

merged 1 commit into from
Aug 28, 2024

Conversation

grzesuav
Copy link
Contributor

No description provided.

@grzesuav
Copy link
Contributor Author

#21

@grzesuav
Copy link
Contributor Author

Behavior:

  • scrape set to true -> prometheus.io/scrape:"true"
  • scrape set to false -> prometheus.io/scrape:"false"
  • scrape not set -> prometheus.io/scrape:"true"

@grzesuav grzesuav mentioned this pull request Aug 23, 2024
Open
@def def merged commit e969159 into coroot:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzesuav @def