-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip #70
base: master
Are you sure you want to change the base?
wip #70
Conversation
class: Grace\ExampleSubscriber | ||
tags: | ||
- | ||
name: Grace\Dispatchers::READ_SUBSCRIBER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know we could use constants in YAML configuration, is this new?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not give any error though but will change to be an xml so it can work, i think @stof is better suited for these types of questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no such thing in YAML. this creates a tag named Grace\Dispatchers::READ_SUBSCRIBER
, which will not be processed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and switching to XML will not allow you to use PHP constants in tag names either. Constants can be used only in parameter and argument values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnugat see? he was more suited, i did not even know that even xml was like this. In any case just switching to the string name is good enough. the compiler pass can be adapted to deal with this nuance.
Sent using Gush