Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for coq-wasm.2.0.1 #3184

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Release for coq-wasm.2.0.1 #3184

merged 5 commits into from
Oct 20, 2024

Conversation

raoxiaojia
Copy link
Contributor

@raoxiaojia raoxiaojia commented Oct 17, 2024

A new version for coq-wasm that compiles with Coq 8.19.

Changelog: https://github.com/WasmCert/WasmCert-Coq/releases/tag/v2.0.1

Upd: Trying to debug this atm, as our own CI succeeds (using Coq-community's CI action).

@raoxiaojia
Copy link
Contributor Author

raoxiaojia commented Oct 17, 2024

Update: It seems that the behaviour of mdx testing has been updated -- in particular, it no longer by default depends on the library being installed. As a result the current CI here tried to run the tests before the library was even compiled (oops).

The new commit should fix this (tested locally, at least).

@raoxiaojia
Copy link
Contributor Author

Checking the newest build log, there seems to be some OOM issue (or something else) when building the project:

- File "theories/dune", lines 1-4, characters 0-142:
- 1 | (coq.theory
- 2 |   (name Wasm)
- 3 |   (package coq-wasm)
- 4 |   (flags -w -notation-overridden -w -abstract-large-number -w -extraction-reserved-identifier))
- (cd _build/default && /builds/J-gEBwyb/0/coq/opam/opam-root-4.14.0-2.1.2-sandbox/4.14.0/bin/coqc -w -notation-
- [...] (Omitted)
- sandbox/4.14.0/lib/coq/theories Coq -R theories Wasm theories/binary_format_tests.v)
- Command got signal KILL.

Is this a known/common issue? Just checking in case there's something I've missed, as I can't seem to replicate this locally (maybe
the CI test environment has a smaller RAM limit?).

In any case, I'll try to push a new commit with this file commented out (maybe the tests require too much resources to be computed on the CI) to investigate the issue.

@palmskog palmskog merged commit a02ab03 into coq:master Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants