Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add potpourri3d and dependencies #28263

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Nov 18, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/happly/meta.yaml, recipes/geometry-central/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/geometry-central/meta.yaml, recipes/happly/meta.yaml) and found some lint.

Here's what I've got...

For recipes/geometry-central/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [27]

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/geometry-central/meta.yaml, recipes/happly/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/potpourri3d/meta.yaml, recipes/happly/meta.yaml, recipes/geometry-central/meta.yaml) and found some lint.

Here's what I've got...

For recipes/potpourri3d/meta.yaml:

For recipes/potpourri3d/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package potpourri3d using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/happly/meta.yaml, recipes/potpourri3d/meta.yaml, recipes/geometry-central/meta.yaml) and found it was in an excellent condition.

@ytausch ytausch marked this pull request as ready for review November 19, 2024 00:01
@ytausch
Copy link
Contributor Author

ytausch commented Nov 19, 2024

@conda-forge/help-python-c @conda-forge/help-c-cpp ready for review!

Co-authored-by: Uwe L. Korn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants