Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vsg #28252

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add vsg #28252

wants to merge 7 commits into from

Conversation

blmaier
Copy link
Contributor

@blmaier blmaier commented Nov 17, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vsg/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vsg/meta.yaml:

  • ❌ The test section contained an unexpected subsection name. import is not a valid subsection name.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vsg/meta.yaml) and found it was in an excellent condition.

@blmaier
Copy link
Contributor Author

blmaier commented Nov 18, 2024

@conda-forge/help-python, ready for review

recipes/vsg/meta.yaml Outdated Show resolved Hide resolved
@ocefpaf
Copy link
Member

ocefpaf commented Nov 18, 2024

The macos failure is a problem in our build system but the Windows failures seems to be related to poorly designed tests upstream as they look like they don't handle the Windows vs Linux path differences properly:

First differing element 0:
'ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number [23 chars]o 3.'
'ERROR: tests/vsg\\entity1.vhd(7)port_007 -- Change number[23 chars]o 4.'

- ['ERROR: tests/vsg/entity2.vhd(8)port_008 -- Change number of spaces after '
-  '*out* to 3.',
-  'ERROR: tests/vsg/entity1.vhd(7)port_007 -- Change number of spaces after '
? ^                 ^

+ ['ERROR: tests/vsg\\entity1.vhd(7)port_007 -- Change number of spaces after '
? ^                 ^^

-  '*in* to 4.']
?              ^

+  '*in* to 4.',
?              ^

+  'ERROR: tests/vsg\\entity2.vhd(8)port_008 -- Change number of spaces after '
+  '*out* to 3.']

Do you want to merge it like that or report it first and try to fix it? There is a chance that the package is fine on Windows but we cannot guarantee it b/c I can't look at all the tests.

@blmaier
Copy link
Contributor Author

blmaier commented Nov 19, 2024

Do you want to merge it like that or report it first and try to fix it? There is a chance that the package is fine on Windows but we cannot guarantee it b/c I can't look at all the tests.

I don't have a Windows host to debug the tests, but I did submit an issue to the upstream. I'd prefer to merge in its current state. Do I need to do anything to bypass the full test on Windows?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 19, 2024

I don't have a Windows host to debug the tests

You don't need. Just check the logs to ensure they are all path issues like that.

but I did submit an issue to the upstream.

👍🏽

I'd prefer to merge in its current state. Do I need to do anything to bypass the full test on Windows?

B/c it is noarch, no. All I need is your 👍🏽 after you check all the failures in the logs and tell me they are not a problem to run this Software on Windows. We would like ao avoid shipping broken stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants