-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vsg #28252
base: main
Are you sure you want to change the base?
Add vsg #28252
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vsg/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review |
The macos failure is a problem in our build system but the Windows failures seems to be related to poorly designed tests upstream as they look like they don't handle the Windows vs Linux path differences properly:
Do you want to merge it like that or report it first and try to fix it? There is a chance that the package is fine on Windows but we cannot guarantee it b/c I can't look at all the tests. |
Co-authored-by: Filipe <[email protected]>
I don't have a Windows host to debug the tests, but I did submit an issue to the upstream. I'd prefer to merge in its current state. Do I need to do anything to bypass the full test on Windows? |
You don't need. Just check the logs to ensure they are all path issues like that.
👍🏽
B/c it is noarch, no. All I need is your 👍🏽 after you check all the failures in the logs and tell me they are not a problem to run this Software on Windows. We would like ao avoid shipping broken stuff. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).