-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for idaes-pse #28221
base: main
Are you sure you want to change the base?
Add recipe for idaes-pse #28221
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/idaes-pse/meta.yaml:
For recipes/idaes-pse/meta.yaml:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/idaes-pse/meta.yaml:
|
f86203b
to
8c2ffbc
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
492b247
to
8baf881
Compare
8baf881
to
5f623a3
Compare
@conda-forge-admin please ping team @conda-forge/help-python This is ready for review. |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
recipes/idaes-pse/meta.yaml
Outdated
# idaes_pse/meta.yaml | ||
{% set name = "idaes-pse" %} | ||
{% set version = "2.6.0" %} | ||
{% set python_min = "3.9" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore.
{% set python_min = "3.9" %} |
recipes/idaes-pse/meta.yaml
Outdated
@@ -0,0 +1,75 @@ | |||
# idaes_pse/meta.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# idaes_pse/meta.yaml |
|
||
requirements: | ||
host: | ||
- python {{ python_min }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are way too much things listed. There should only be the things that are required to build the package, e.g. setuptools
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I see what you mean. Done in ed160f7
- idaes | ||
- idaes.core | ||
- idaes.core.base | ||
commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commands: | |
commands: | |
- pip check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in f98fa23
- sympy | ||
|
||
test: | ||
requires: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires: | |
requires: | |
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b0f4070
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/idaes-pse/meta.yaml:
For recipes/idaes-pse/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11961677680. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks a lot for the feedback @xhochy. I believe I have addressed all your comments, but let me know if that's not the case. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).