Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for pcre2 #3514

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for pcre2. The current pinned version is 10.37, the latest available version is 10.40 and the max pin pattern is x.x. This migration will impact 15 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 10.37 to 10.40.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping pcre2
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3233209045, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner October 12, 2022 10:16
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/pcre2 and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member

There are no records for PCRE2 10.35+ at https://abi-laboratory.pro/index.php?view=timeline&l=pcre2

@jaimergp jaimergp self-assigned this Oct 22, 2022
@hmaarrfk
Copy link
Contributor

Honestly, conda forge with the auto bots has become "ahead" of abi-pro in many cases.

I don't really like repo patches, I find them very obscure.

@xhochy
Copy link
Member

xhochy commented Oct 24, 2022

I would also argue that it is probably easier to run through a migration here than to spent time repodata-patching and investigating deeply about the ABI stability.

@hmaarrfk
Copy link
Contributor

We can also have a deeper discussion in
#3368

@jaimergp
Copy link
Member

jaimergp commented Nov 1, 2022

I'd say it's also a matter of resources. For big migrations, if there were no ABI changes, it might be too much of a waste. But for 15 feedstocks maybe it's not too much and we can take care of the stalled PRs?

@jaimergp
Copy link
Member

jaimergp commented Nov 1, 2022

I found this issue: PCRE2Project/pcre2#56 (comment)

I don't know if it's fully incompatible or not, but since there are "some projects" with problems, I'd say we rebuild for safety.

@xhochy
Copy link
Member

xhochy commented Nov 5, 2022

Let's do it then.

@xhochy xhochy merged commit 0ba4c4e into conda-forge:main Nov 5, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the new_pin-pcre2-10.40-0-_h740952 branch November 5, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants