Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spake2.txt #357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matter-it-does
Copy link

@matter-it-does matter-it-does commented Dec 7, 2021

The dependency on spake2 is not working. When installing wormhole, linux-64/spake2-0.8-0.tar.bz2 is downloaded. This doesn't work with the error message in conda-forge/magic-wormhole-feedstock#12 . It installs files in lib/python2.7/site-packages/spake2

Right dependency is noarch/spake2-0.8-py_3.tar.bz2. It installs files in site-packages/spake2.


Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

@matter-it-does matter-it-does requested a review from a team as a code owner December 7, 2021 16:02
@matter-it-does
Copy link
Author

matter-it-does commented Dec 7, 2021

@conda-forge-admin, please ping conda-forge/magic-wormhole-feedstock

@isuruf
Copy link
Member

isuruf commented Dec 7, 2021

cc @CJ-Wright

@isuruf
Copy link
Member

isuruf commented Dec 7, 2021

It's not workhole that's broken. It's spake2. You should mark spake2 non-noarch packages as broken.

@matter-it-does matter-it-does changed the title Create wormhole.txt Create spake2.txt Dec 7, 2021
@beckermr
Copy link
Member

beckermr commented Dec 7, 2021

Ugh we should add syntax so the bot ignores the @ sign here for that admin command.

@beckermr
Copy link
Member

beckermr commented Dec 7, 2021

@beckermr
Copy link
Member

beckermr commented Dec 7, 2021

@conda-forge-admin, please ping conda-forge/magic-wormhole-feedstock

@beckermr
Copy link
Member

beckermr commented Dec 7, 2021

@conda-forge-admin, please ping conda-forge/magic-wormhole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants