fix requestId to rotate after 255 calls. colyseus/colyseus#242

colyseus · May 18, 2019 · 1938dc1 · 1938dc1
1 parent f1fd74d
commit 1938dc1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/dist/colyseus.js b/dist/colyseus.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "colyseus.js",
-  "version": "0.10.5",
+  "version": "0.10.6",
   "description": "Multiplayer Game Client for the Browser",
   "keywords": [
     "colyseus",

diff --git a/src/Client.ts b/src/Client.ts
@@ -45,7 +45,7 @@ export class Client {
 
     public getAvailableRooms(roomName: string, callback: (rooms: RoomAvailable[], err?: string) => void) {
         // reject this promise after 15 seconds.
-        const requestId = ++this.requestId;
+        const requestId = this.getNextRequestId();
         const removeRequest = () => delete this.roomsAvailableRequests[requestId];
         const rejectionTimeout = setTimeout(() => {
             removeRequest();
@@ -76,7 +76,7 @@ export class Client {
         reuseRoomInstance?: Room<T>,
         retryCount?: number,
     ) {
-        options.requestId = ++this.requestId;
+        options.requestId = this.getNextRequestId();
 
         const room = reuseRoomInstance || this.createRoom<T>(roomName, options);
 
@@ -201,4 +201,8 @@ export class Client {
 
     }
 
+    protected getNextRequestId() {
+        return (++this.requestId % 255);
+    }
+
 }