Skip to content

Commit

Permalink
fix(Inline-toolbar): fake selection stays on screen after toggling co…
Browse files Browse the repository at this point in the history
…nvert to (#2768)

* Fix not removing fake selection on convert to toggle

* Update version and changelog

* Update docs/CHANGELOG.md

Co-authored-by: Peter <[email protected]>

---------

Co-authored-by: Peter <[email protected]>
  • Loading branch information
TatianaFomina and neSpecc authored Jul 9, 2024
1 parent 4a4981e commit ba8fa73
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

### 2.30.1

- `Fix` – Remove fake selection after multiple "convert to" inline tool toggles

### 2.30.0

- `New` – Block Tunes now supports nesting items
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/editorjs",
"version": "2.30.0",
"version": "2.30.1",
"description": "Editor.js — open source block-style WYSIWYG editor with JSON output",
"main": "dist/editorjs.umd.js",
"module": "dist/editorjs.mjs",
Expand Down
3 changes: 2 additions & 1 deletion src/components/utils/popover/popover-inline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ export class PopoverInline extends PopoverDesktop {
*/
protected override showNestedItems(item: PopoverItemDefault | PopoverItemHtml): void {
if (this.nestedPopoverTriggerItem === item) {
this.nestedPopoverTriggerItem = null;
this.destroyNestedPopoverIfExists();

this.nestedPopoverTriggerItem = null;

return;
}
Expand Down

0 comments on commit ba8fa73

Please sign in to comment.