Add support for Chef Solo/RightScale, fill out metadata, more directive support in template #4
Conversation
|
Nice work Chris! |
This reverts commit f51fcc2.
| @@ -22,6 +22,9 @@ | |||
| default[:collectd][:types_db] = ["/usr/share/collectd/types.db"] | |||
| default[:collectd][:interval] = 10 | |||
| default[:collectd][:read_threads] = 5 | |||
| default[:collectd][:fqdn_lookup] = "true" | |||
There was a problem hiding this comment.
Is there a particular reason to use a string instead of a real Ruby boolean? Usually nice to use native types when possible.
|
Any update? |
| @@ -5,3 +5,86 @@ | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version "1.0.0" | |||
| supports "ubuntu" | |||
|
|
|||
| depends "apache2" | |||
There was a problem hiding this comment.
It only depends on apache2 if collectd_web is used. We don't use it for example
There was a problem hiding this comment.
@kpumuk Chef doesn't support optional dependencies (in metadata) so technically its a dependency. What the best practice is, I'm not sure but personally I think its better to do this as recipes don't have a mechanism to even check nicely on the cookbook needed (which would also create a lot of extra redundant code in every cookbook that has optional deps).
…d servers are found or provided.
|
@coderanger I have finally updated this pr! Please let me know if it needs more work before it can be merged. Thanks for your year-long patience :) |
|
Just as a heads up I'm about to get really busy for a week or two, and this no longer cleanly merges, so it may take a while to get it sorted. |
|
No problem coderanger. I'll go on standby and look at for any action items I should do. Worse case, I don't mind re-doing the whole thing with a fresh fork, but it would be cool to avoid that if possible. |
|
Perhaps you could rebase on top of master so this becomes a clean merge? |
|
@coderanger hmm what should we do now? Please let me know :) |
The client recipe has been improved to support chef-solo where collectd servers can be specified via a node attribute.
Metadata has been completed (recipes and attribute definitions) as well as adding metadata.json back as this is required for usage on RightScale.
The Hostname and FQDNLookup directives have been added to the template for user specifiable configuration to be more flexible on arbitrary node requirements.