Added OmatAdd operator support #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
2 times, most recently
from
97b20d1
to
eaa54f7
Compare
OuadiElfarouki
force-pushed
the
omatcopy_pr
branch
from
9f8e46f
to
5ef9ac0
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
from
eaa54f7
to
6aba354
Compare
OuadiElfarouki
force-pushed
the
omatcopy_pr
branch
from
5ef9ac0
to
fd7d8ce
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
3 times, most recently
from
14d8afd
to
20a394d
Compare
OuadiElfarouki
force-pushed
the
omatcopy_pr
branch
from
ae4aa79
to
ba0da56
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
2 times, most recently
from
13d08ed
to
c73b7d4
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
from
d2587d7
to
796efc2
Compare
s-Nick
force-pushed
the
omatadd_pr
branch
4 times, most recently
from
95016bb
to
944a289
Compare
OuadiElfarouki
force-pushed
the
omatcopy_pr
branch
from
e6a6654
to
cf2f38c
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
from
55eb6b8
to
501a66d
Compare
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
from
501a66d
to
da20887
Compare
|
Squashed all commit history into 3 base commits & re-based to merge on Master. |
OuadiElfarouki
force-pushed
the
omatadd_pr
branch
from
da20887
to
02e2859
Compare
pgorlani
reviewed
Aug 4, 2023
pgorlani
reviewed
Aug 4, 2023
pgorlani
reviewed
Aug 4, 2023
pgorlani
reviewed
Aug 4, 2023
Co-authored-by: pgorlani <[email protected]>
Co-authored-by: pgorlani <[email protected]>
pgorlani
reviewed
Aug 4, 2023
pgorlani
reviewed
Aug 8, 2023
pgorlani
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the OmatCopy & OmatCopy2 PR by adding support to OmatAdd as a separate operator with a separate implementation of its transpose kernel(s).
OneMKL Specification used as reference for the interface & implementation : Link
Co-Author : @s-Nick