-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Recent Releases table #19015
base: main
Are you sure you want to change the base?
Update Recent Releases table #19015
Conversation
Files changed: |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
| [v24.1](#v24-1) | Regular | 2024-05-20 | v24.1.4 | | ||
| [v23.2](#v23-2) | Regular | 2024-02-05 | v23.2.10 (LTS) | | ||
| [v23.1](#v23-1) | Regular | 2023-05-15 | v23.1.25 (LTS) | | ||
| [v24.2](#v24-2) | Innovation | 2024-09-25 | v24.2.3 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These GA dates do not look right to me when I look at the versions.csv
, where the release_date
for v24.2 is listed as 2024-08-12
, for v24.1 it is listed as 2024-05-20
, for v23.2 it is listed as 2024-02-05
, etc. Where are you seeing these other dates?
The Latest patch release
column is not ideal as it needs to be manually maintained. Is the column valuable enough to take that on, or to take on cycles to automate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right; I updated these to the latest patch release date in error!
Also, you have a good point about maintainability — I think we should drop the column and I'll create an issue to consider automated display of it, instead.
I'll close this PR and open another, if that sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Manual update of the Recent releases (https://www.cockroachlabs.com/docs/releases#recent-releases) table that we need to automate.